-
Notifications
You must be signed in to change notification settings - Fork 480
chore(lib-injection): unpack wheels to arch specific directories #15975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate taegyunkim/prof-13437-arch (7729a89) with baseline main (33bcb50) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 23/23✅ ospathbasename_aspectTime: ✅ 499.266µs (SLO: <700.000µs 📉 -28.7%) vs baseline: 📈 +17.9% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 432.045µs (SLO: <700.000µs 📉 -38.3%) vs baseline: ~same Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 626.975µs (SLO: <700.000µs 📉 -10.4%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 637.823µs (SLO: <700.000µs -8.9%) vs baseline: +0.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 347.344µs (SLO: <700.000µs 📉 -50.4%) vs baseline: -0.7% ✅ ospathnormcase_noaspectTime: ✅ 358.144µs (SLO: <700.000µs 📉 -48.8%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 495.458µs (SLO: <700.000µs 📉 -29.2%) vs baseline: +0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 502.283µs (SLO: <700.000µs 📉 -28.2%) vs baseline: -0.2% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 376.386µs (SLO: <700.000µs 📉 -46.2%) vs baseline: +0.7% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 73.411µs (SLO: <700.000µs 📉 -89.5%) vs baseline: +0.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 457.266µs (SLO: <700.000µs 📉 -34.7%) vs baseline: +0.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 469.716µs (SLO: <700.000µs 📉 -32.9%) vs baseline: +1.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.486µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +17.5% Memory: ✅ 35.409MB (SLO: <38.000MB -6.8%) vs baseline: +5.3% ✅ 1-count-metrics-100-timesTime: ✅ 210.350µs (SLO: <220.000µs -4.4%) vs baseline: -0.1% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +5.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.314µs (SLO: <20.000µs 📉 -83.4%) vs baseline: -1.4% Memory: ✅ 35.468MB (SLO: <38.000MB -6.7%) vs baseline: +5.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.931µs (SLO: <230.000µs -5.7%) vs baseline: -1.1% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.4% ✅ 1-gauge-metric-1-timesTime: ✅ 2.158µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +5.5% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.728µs (SLO: <150.000µs -8.8%) vs baseline: -0.2% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.095µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -0.1% Memory: ✅ 35.468MB (SLO: <38.000MB -6.7%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 224.219µs (SLO: <250.000µs 📉 -10.3%) vs baseline: ~same Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +5.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.563ms (SLO: <22.000ms -6.5%) vs baseline: +0.3% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.239ms (SLO: <2.550ms 📉 -12.2%) vs baseline: +1.2% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: ~same Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.231ms (SLO: <2.550ms 📉 -12.5%) vs baseline: ~same Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.531µs (SLO: <20.000µs 📉 -77.3%) vs baseline: -0.5% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +5.2% ✅ flush-100-metricsTime: ✅ 176.034µs (SLO: <250.000µs 📉 -29.6%) vs baseline: -0.1% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.180ms (SLO: <2.500ms 📉 -12.8%) vs baseline: -0.5% Memory: ✅ 36.372MB (SLO: <38.750MB -6.1%) vs baseline: +4.7% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.616ms (SLO: <32.950ms -4.0%) vs baseline: +0.1% Memory: ✅ 36.805MB (SLO: <39.250MB -6.2%) vs baseline: +5.2% ✅ mediumTime: ✅ 3.141ms (SLO: <3.200ms 🟡 -1.8%) vs baseline: -1.3% Memory: ✅ 35.271MB (SLO: <38.750MB -9.0%) vs baseline: +4.9% ✅ smallTime: ✅ 363.828µs (SLO: <370.000µs 🟡 -1.7%) vs baseline: +3.4% Memory: ✅ 35.212MB (SLO: <38.750MB -9.1%) vs baseline: +4.7%
|
|
@brettlangdon Given that #15943 is not yet merged, how much confidence do we have that this change won't break any downstream pipeline? |
Description
https://datadoghq.atlassian.net/browse/PROF-13437
Would wait for #15943 to be merged first for test coverage
Testing
Risks
Additional Notes